Skip to content

Tools: Topology2: cavs-nocodec: Fix formats for Port0 first/second ca… #10081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Jul 1, 2025
Merged

Tools: Topology2: cavs-nocodec: Fix formats for Port0 first/second ca… #10081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions tools/topology/topology2/cavs-nocodec.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,43 @@ IncludeByKey.PASSTHROUGH {
Object.Control.mixer.1 {
name 'Post Demux $SSP0_PCM_NAME Capture Volume'
}

num_input_audio_formats 1

Object.Base.input_audio_format [
# 32-bit 48KHz 2ch
{
in_bit_depth 32
in_valid_bit_depth 32
}
]

num_output_audio_formats 1
Object.Base.output_audio_format [
{
out_bit_depth 32
out_valid_bit_depth 32
}
]
}
Object.Widget.module-copier.2 {
num_input_audio_formats 1

Object.Base.input_audio_format [
# 32-bit 48KHz 2ch
{
in_bit_depth 32
in_valid_bit_depth 32
}
]

num_output_audio_formats 1
Object.Base.output_audio_format [
{
out_bit_depth 32
out_valid_bit_depth 32
}
]
}
}

Expand All @@ -429,6 +466,43 @@ IncludeByKey.PASSTHROUGH {
Object.Control.mixer.1 {
name 'Post Demux $SSP0_CAPTURE_PCM Volume'
}

num_input_audio_formats 1

Object.Base.input_audio_format [
# 32-bit 48KHz 2ch
{
in_bit_depth 32
in_valid_bit_depth 32
}
]

num_output_audio_formats 1
Object.Base.output_audio_format [
{
out_bit_depth 32
out_valid_bit_depth 32
}
]
}
Object.Widget.module-copier.2 {
num_input_audio_formats 1

Object.Base.input_audio_format [
# 32-bit 48KHz 2ch
{
in_bit_depth 32
in_valid_bit_depth 32
}
]

num_output_audio_formats 1
Object.Base.output_audio_format [
{
out_bit_depth 32
out_valid_bit_depth 32
}
Comment on lines +473 to +504
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] These input/output format blocks are duplicated for both Port0 branches. Consider extracting the 32-bit format definition into a shared template or macro to reduce repetition and ease future updates.

Suggested change
# 32-bit 48KHz 2ch
{
in_bit_depth 32
in_valid_bit_depth 32
}
]
num_output_audio_formats 1
Object.Base.output_audio_format [
{
out_bit_depth 32
out_valid_bit_depth 32
}
]
}
Object.Widget.module-copier.2 {
num_input_audio_formats 1
Object.Base.input_audio_format [
# 32-bit 48KHz 2ch
{
in_bit_depth 32
in_valid_bit_depth 32
}
]
num_output_audio_formats 1
Object.Base.output_audio_format [
{
out_bit_depth 32
out_valid_bit_depth 32
}
# Use shared 32-bit format template
@include:32bit_audio_format
]
num_output_audio_formats 1
Object.Base.output_audio_format [
# Use shared 32-bit format template
@include:32bit_audio_format
]
}
Object.Widget.module-copier.2 {
num_input_audio_formats 1
Object.Base.input_audio_format [
# Use shared 32-bit format template
@include:32bit_audio_format
]
num_output_audio_formats 1
Object.Base.output_audio_format [
# Use shared 32-bit format template
@include:32bit_audio_format

Copilot uses AI. Check for mistakes.
]
}
}
]
Expand Down
Loading