Name change #40
Open
Name change #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
reviewed
Jan 20, 2020
org.sofproject.ui/src/org/sofproject/ui/wizards/NewAudioDevNodeWizard.java
Show resolved
Hide resolved
Use 'configuration' instead of 'connection' in wizard window to better reflect the real usage. Signed-off-by: Emilia Dominiak <emilia.dominiak@intel.com>
|
Please explain in the commit message why "configuration" is better. A single 'audio dev node' project represents a single target remote (actually might be localhost as well) node, often called dut (device under test). So "connection" sounded quite good to me. (btw, duplicates should be not permitted to avoid issues with file sync). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #26