ASoC: sdw_utils: subtract the endpoint that is not present #5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
ranj063
reviewed
Dec 12, 2025
| */ | ||
| if (dai_info->quirk && | ||
| !(dai_info->quirk_exclude ^ !!(dai_info->quirk & ctx->mc_quirk))) | ||
| !(dai_info->quirk_exclude ^ !!(dai_info->quirk & ctx->mc_quirk))) { |
Collaborator
There was a problem hiding this comment.
@bardliao can you also add the Link to the bug?
When asoc_sdw_count_sdw_endpoints() count the num_ends, it doesn't skip the unpresented endpoints. But, asoc_sdw_parse_sdw_endpoints() will skip the unpresented endpoints either by quirk or the SDCA function doesn't show up the endpoint. The endpoint number mismatches between count and parse and the machine driver will show up a warning about it. Fixes: 26ee34d ("ASoC: sdw_utils: Add codec_conf for every DAI") Closes: thesofproject#5620 Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
fix-endpoint-count
branch
from
5864395 to
391ee1c
Compare
ujfalusi
approved these changes
Dec 12, 2025
|
Yeah all looks good to me, feel free to add my reviewed-by. |
charleskeepax
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asoc_sdw_count_sdw_endpoints() count the num_ends, it doesn't skip the unpresented endpoints. But, asoc_sdw_parse_sdw_endpoints() will skip the unpresented endpoints either by quirk or the SDCA function doesn't show up the endpoint. The endpoint number mismatches between count and parse and the machine driver will show up a warning about it.
Fixes: 26ee34d ("ASoC: sdw_utils: Add codec_conf for every DAI")