fix: use keyword arguments for Neo4jGraph initialization (#3906)#6
Open
fix: use keyword arguments for Neo4jGraph initialization (#3906)#6
Conversation
Root cause: Neo4jGraph.__init__ parameter order is (url, username, password, token, database, ...) but the code passed database as the 4th positional argument, which maps to the token parameter. This caused the database value to be silently used as token, while the actual database defaulted to 'neo4j'. Fix: Use explicit keyword arguments to ensure each value maps to the correct parameter regardless of positional order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mem0ai#3906.
Root cause:
databasewas passed as the 4th positional arg toNeo4jGraph.__init__, but position 4 istoken. This silently used the database value as token while defaulting database to'neo4j'.Fix: Use explicit keyword arguments for all parameters.