fix: avoid sending both temperature and topP in Bedrock Converse API (#4004)#3
Open
fix: avoid sending both temperature and topP in Bedrock Converse API (#4004)#3
Conversation
…em0ai#4004) Root cause: The _generate_with_tools() and _generate_standard() methods unconditionally included both temperature and topP in inferenceConfig. Newer Anthropic Claude models on Bedrock reject requests containing both parameters simultaneously with a ValidationException. Fix: Extract inference config building into _build_inference_config() helper that only includes topP when temperature is not set. This prevents the conflict while maintaining backward compatibility for models that accept both parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mem0ai#4004.
Root cause:
_generate_with_tools()and_generate_standard()unconditionally sent bothtemperatureandtopPininferenceConfig. Newer Anthropic Claude models on Bedrock reject this.Fix: Extracted
_build_inference_config()helper that only includestopPwhentemperatureis not set.