fix: add missing limit, threshold, and infer params to REST API models (#3976)#2
Open
fix: add missing limit, threshold, and infer params to REST API models (#3976)#2
Conversation
mem0ai#3976) Root cause: The Pydantic request models SearchRequest and MemoryCreate did not declare limit, threshold, and infer fields. Since Pydantic v2 defaults to extra='ignore', these params were silently dropped from requests, making it impossible for clients to control result count, similarity filtering, or fact extraction behavior. Fix: Add Optional fields for limit and threshold to SearchRequest, and infer to MemoryCreate. The existing model_dump() + **params pattern automatically forwards these to Memory.search() and Memory.add().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mem0ai#3976.
Root cause: Pydantic request models
SearchRequestandMemoryCreatedid not declarelimit,threshold, andinferfields, so Pydantic v2 silently dropped them.Fix: Added
limit: Optional[int]andthreshold: Optional[float]toSearchRequest, andinfer: Optional[bool]toMemoryCreate.