Improve PhotoView for Android #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor PhotoView to add Android support and apply platform-specific layouts. Introduce `applyPhotoLayout` to handle conditional layout logic for different platforms. Create `iosPhotoView` and `androidPhotoView` functions to streamline image loading methods dependent on the OS. These changes enable better flexibility and performance on both iOS and Android, ensuring a consistent user experience across platforms.
Indent preprocessor directives inside ViewBuilder functions to improve code readability. This change ensures consistent indenting across platform-specific View implementations and maintains uniformity in formatting. This refactoring does not alter any functionality but enhances maintainability.
Change the function name from `iosPhotoView` to `iOSPhotoView` to maintain consistency with Swift naming conventions and improve code readability. This change ensures that the case of 'iOS' follows standard practices, reflecting platform-specific coding style.
MarcHidalgo5
changed the title
Update the `skip` package dependency to version 1.7.0 for additional features and improvements. Refactor the `PhotoView.swift` file to remove platform-specific function implementations (`iOSPhotoView` and `androidPhotoView`), consolidating loading logic. Enhance the use of AsyncImage for Android and streamline the aspect ratio application by removing the `applyPhotoLayout` extension method in favor of directly using `.aspectRatio`.
piercifani
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.