This repository was archived by the owner on Jul 24, 2020. It is now read-only.
changed project structure guideline, switched from AOSP guidelines to…#3
Open
swavkulinski wants to merge 3 commits intomasterfrom
Open
changed project structure guideline, switched from AOSP guidelines to…#3swavkulinski wants to merge 3 commits intomasterfrom
swavkulinski wants to merge 3 commits intomasterfrom
Conversation
added 3 commits
February 1, 2016 17:55
Contributor
There was a problem hiding this comment.
Personal opinion but I'm not a fan of having the network, model, parsers and persistence layer together
There was a problem hiding this comment.
Network should definitely separated from repository.
|
I know we're migrating to Java Codestyle, but what about things like Logging, Enums vs. IntDef or StringDef, and other specific Android components like BroadcastReceivers, Services? |
|
@swavkulinski any updates on this? do we merge? do we make changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Google Java Style
In short.
Organise project by Groups of features/ features
Use Google Java Style
@kleinsenberg @qasimtab @juanyanezgc @JamesScottTAB