Skip to content

Conversation

@jjuhl
Copy link
Contributor

@jjuhl jjuhl commented Jan 6, 2026

Just a few small cleanups/fixes.

@texus
Copy link
Owner

texus commented Jan 6, 2026

The BackendFontFactory::createFont(), BackendRenderer::createText() and BackendRenderer::createTexture() virtual functions can't be made const for backwards compatibility. They are base classes for custom backends. I've added a note to add the const if I ever start working on TGUI 2.

While the contains() function is better, that part of the code is a test for the count() function 😄

Explicitly casting  something (variable, expression, ...)  to the same
type as that "something" already is, is fairly pointless.
@jjuhl
Copy link
Contributor Author

jjuhl commented Jan 7, 2026

Makes perfect sense :)
I've dropped those two commits and rebased on the latest 1.x branch.

@texus texus mentioned this pull request Jan 7, 2026
@jjuhl
Copy link
Contributor Author

jjuhl commented Jan 7, 2026

Rescued a few commits from the include-cleanup-part1 branch/PR as we discussed.

jjuhl added 2 commits January 7, 2026 19:47
To ensure that the header is self contained.
Remove a few includes of header files that are not directly used by
the files including them.
@texus texus merged commit aec13c3 into texus:1.x Jan 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants