Add support for more timeouts to Nexus operations#390
Open
Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:mainfrom
Open
Add support for more timeouts to Nexus operations#390Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:mainfrom
Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:mainfrom
Conversation
cretz
reviewed
Feb 18, 2026
| if target_host.empty? | ||
| @server = Temporalio::Testing::WorkflowEnvironment.start_local( | ||
| logger: Logger.new($stdout), | ||
| dev_server_download_version: ENV.fetch('TEMPORAL_DEV_SERVER_VERSION', 'default'), |
Member
There was a problem hiding this comment.
Would rather hardcode this if it's needed for tests to pass rather than have callers have to set an env var for tests to pass. We do this in other SDKs as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for more timeouts to Nexus operations
closes #389
Note
Medium Risk
Touches workflow command construction for Nexus operations, so mismapped timeout fields could change runtime behavior; coverage is improved with explicit timeout-type tests.
Overview
Adds support for Nexus operation
schedule_to_start_timeoutandstart_to_close_timeoutend-to-end: new keyword args onWorkflow::NexusClient#start_operation/#execute_operation, plumbed throughStartNexusOperationInputinto theschedule_nexus_operationworkflow command.Updates type signatures (
.rbs) and expands Nexus workflow tests to assert the new timeout types are raised (SCHEDULE_TO_STARTwhen no worker picks up the task;START_TO_CLOSEwhen an async operation starts but never completes). CI/tests also pin the local Temporal dev server version viaTEMPORAL_DEV_SERVER_VERSION.Written by Cursor Bugbot for commit b54aa03. This will update automatically on new commits. Configure here.