Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sushisource
reviewed
Feb 13, 2026
|
|
||
| use Temporal\Api\Common\V1\Payload; | ||
|
|
||
| class RawValueConverter extends Converter |
Member
There was a problem hiding this comment.
The other language SDKs don't use a specific converter for RawValue - rather, it is expected that RawValue always has it's inner value directly passed through as the payload (ex: what if the user wants to explicitly set some other unusual metadata encoding while using raw value? This current solution prevents that).
So, for example, in the Python SDK, the composite converter explicitly handles things typed as RawValue before delegating to other converters: https://github.com/temporalio/sdk-python/blob/b69ac9258bc13c4a3d454f4c4a8d98b4f834babe/temporalio/converter.py#L377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Closes #574
Checklist
Closes
How was this tested: