Merged
Conversation
cretz
approved these changes
Jan 5, 2026
src/Dsl/DslTypes.cs
Outdated
| required public ParallelBranches Parallel { get; init; } | ||
| } | ||
|
|
||
| public record DslInput |
Member
There was a problem hiding this comment.
Pedantic, but I think this should be the top-level type (and file name), and it should have a static Parse() and all of these other records should be inner classes of it.
src/Dsl/DslWorkflow.workflow.cs
Outdated
Comment on lines
9
to
14
| private Dictionary<string, object> variables = new(); | ||
|
|
||
| [WorkflowRun] | ||
| public async Task<Dictionary<string, object>> RunAsync(DslInput input) | ||
| { | ||
| variables = new Dictionary<string, object>(input.Variables); |
Member
There was a problem hiding this comment.
I would recommend using [WorkflowInit] for this. E.g.
private readonly Dictionary<string, object> variables;
[WorkflowInit]
public DslWorkflow(DslInput input) => variables = input.Variables;
src/Dsl/DslWorkflow.workflow.cs
Outdated
| case ActivityStatement activityStmt: | ||
| // Invoke activity loading arguments from variables and optionally storing result as a variable | ||
| var args = activityStmt.Activity.Arguments | ||
| .Select(argName => variables.TryGetValue(argName, out var value) ? value : string.Empty) |
Member
There was a problem hiding this comment.
Would be ok using index accessor and letting this just throw on key not found to keep logic simpler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Sample request: DSL #19
How was this tested:
Manually + tests.
Any docs updates needed?
README updated