activity/shutdown: Increase timeout for ScheduleToClose for succeeding workflow#750
Merged
yuandrew merged 2 commits intotemporalio:mainfrom Feb 11, 2026
Merged
Conversation
yuandrew
force-pushed
the
improve-shutdown-flake
branch
from
a7784e5 to
03985d9
Compare
cretz
reviewed
Feb 10, 2026
| }; | ||
| var ignoreOptions = new ActivityOptions | ||
| { | ||
| ScheduleToCloseTimeout = TimeSpan.FromSeconds(2), |
Member
There was a problem hiding this comment.
Can this go back to 300ms? No need to add an extra 1.7s to the tests right? The other tests do just fine confirming that worker shutdown is delivered.
yuandrew
changed the title
cretz
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Create separate timeout
30sfor the successing/failing workflows, while keeping theignoreworkflow at 300ms. This should not increase the time it takes for tests to finish, but should reduce the raciness, ifcancellSuccess/cancelFailurecouldn't ocmplete within 300msChange TS to use setTimeout to not react to cancellation.
Why?
Reduce test flakes
Checklist
Closes
How was this tested: