fix: resolve test patching failure in test_evaluate_multiple_models.py#26
Closed
federetyk wants to merge 1 commit intotechwolf-ai:mainfrom
Closed
fix: resolve test patching failure in test_evaluate_multiple_models.py#26federetyk wants to merge 1 commit intotechwolf-ai:mainfrom
federetyk wants to merge 1 commit intotechwolf-ai:mainfrom
Conversation
Contributor
Author
|
Superseded by a cleaner fix: renaming the module to avoid the naming collision entirely. See this comment and #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue: #25
Description
Fixed the
AttributeErrorintest_evaluate_multiple_models.pycaused by incorrect mock patchingThe issue:
patch("workrb.evaluate.evaluate")fails becauseworkrb.evaluateresolves to theevaluatefunction (exported in__init__.py) rather than the module, causing Python to look for anevaluateattribute on the function objectSolution: Use
patch.object()with an explicitly imported module reference to ensure the correct target is patchedChanges:
import importlibevaluate_module = importlib.import_module("workrb.evaluate")to get explicit module referencepatch("workrb.evaluate.evaluate")withpatch.object(evaluate_module, "evaluate")Checklist