Issue #15 fix: User update (patch) is not working for resource app=users&resource=user
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce `com_api&app=users&resource=user`
# Conflicts: # src/users/user.php
manojLondhe
changed the title
com_api&app=users&resource=userapp=users&resource=user
coolbung
reviewed
Apr 21, 2019
| { | ||
| if ($fidentifier) | ||
| // Forced user creation | ||
| if ($fIdentifier) |
Member
There was a problem hiding this comment.
Combine this with the else above into an elseif condition ?
coolbung
reviewed
Apr 21, 2019
|
|
||
| // Get current logged in user. | ||
| $my = JFactory::getUser(); | ||
| $me = JFactory::getUser(); |
Member
There was a problem hiding this comment.
The user object is already available in $this->plugin->get('user') can you confirm it is ok to use either ?
vaivk369
reviewed
May 9, 2019
| { | ||
| if ($formData['password'] == '') | ||
| // Validate required fields | ||
| if ($formData['username'] == '' || $formData['name'] == '' || $formData['email'] == '' || $formData['password'] == '') |
There was a problem hiding this comment.
We can create user without passing the password in joomla.
@manojLondhe
| // Forced user creation | ||
| if ($fIdentifier) | ||
| { | ||
| $user = new JUser; |
There was a problem hiding this comment.
If id is provided, and is exist then user should get updated
@manojLondhe @coolbung
vaivk369
pushed a commit
to vaivk369/com_api.plugins.users
that referenced
this pull request
May 9, 2019
Member
Author
|
closing in favor of #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com_api&app=users&resource=user#15 fix: User update (patch) is not working for resourceapp=users&resource=user