This repository was archived by the owner on May 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Add a capability disableSeccomp to disable the seccomp system call filter. #532
Open
jschwartzentruber
wants to merge
4
commits into
taskcluster:master
Choose a base branch
from
jschwartzentruber:disable-seccomp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add a capability disableSeccomp to disable the seccomp system call filter. #532
jschwartzentruber
wants to merge
4
commits into
taskcluster:master
from
jschwartzentruber:disable-seccomp
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to run `rr` inside a container, as described here: https://github.com/mozilla/rr/wiki/Docker
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
walac
suggested changes
Dec 11, 2019
Contributor
walac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would you mind adding an worker configuration to disable this feature similar to allowPrivileged ?
walac
reviewed
Dec 11, 2019
jschwartzentruber
added a commit
to jschwartzentruber/community-tc-config
that referenced
this pull request
Dec 18, 2019
jschwartzentruber
added a commit
to jschwartzentruber/community-tc-config
that referenced
this pull request
Dec 19, 2019
jschwartzentruber
added a commit
to jschwartzentruber/community-tc-config
that referenced
this pull request
Jan 6, 2020
walac
pushed a commit
to taskcluster/community-tc-config
that referenced
this pull request
Jan 7, 2020
Contributor
|
It took a while but the tasks now run, it feels like disableSeccomp tasks are failing |
Contributor
|
@djmitche another one: |
Contributor
|
Not my PR, but I pushed that change :) |
Contributor
Ops, I commented in the wrong PR, it actually applies to yours, sorry |
9e7c1b5 to
fc9df43
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to run
rrinside a container, as described here: https://github.com/mozilla/rr/wiki/DockerI haven't been able to run the test locally, mocha says: "pending". I'm hoping it'll be run in CI.