Skip to content
This repository was archived by the owner on May 9, 2020. It is now read-only.

Conversation

@jschwartzentruber
Copy link
Contributor

This is required to run rr inside a container, as described here: https://github.com/mozilla/rr/wiki/Docker

I haven't been able to run the test locally, mocha says: "pending". I'm hoping it'll be run in CI.

@community-tc-integration
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@walac walac closed this Dec 11, 2019
@walac walac reopened this Dec 11, 2019
@walac walac self-requested a review December 11, 2019 14:06
Copy link
Contributor

@walac walac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would you mind adding an worker configuration to disable this feature similar to allowPrivileged ?

@walac walac closed this Dec 11, 2019
@walac walac reopened this Dec 11, 2019
@jschwartzentruber jschwartzentruber changed the title Add a feature disableSeccomp to disable the seccomp system call filter. Add a capability disableSeccomp to disable the seccomp system call filter. Dec 18, 2019
jschwartzentruber added a commit to jschwartzentruber/community-tc-config that referenced this pull request Dec 18, 2019
jschwartzentruber added a commit to jschwartzentruber/community-tc-config that referenced this pull request Dec 19, 2019
@walac walac closed this Jan 6, 2020
@walac walac reopened this Jan 6, 2020
jschwartzentruber added a commit to jschwartzentruber/community-tc-config that referenced this pull request Jan 6, 2020
walac pushed a commit to taskcluster/community-tc-config that referenced this pull request Jan 7, 2020
@walac walac closed this Jan 9, 2020
@walac walac reopened this Jan 9, 2020
@walac walac closed this Jan 9, 2020
@walac walac reopened this Jan 9, 2020
@walac
Copy link
Contributor

walac commented Jan 9, 2020

It took a while but the tasks now run, it feels like disableSeccomp tasks are failing

@walac
Copy link
Contributor

walac commented Jan 13, 2020

@djmitche another one:

diff --git a/test/dockerworker.js b/test/dockerworker.js
index 8ed1eef8..7ef763d6 100644
--- a/test/dockerworker.js
+++ b/test/dockerworker.js
@@ -64,7 +64,7 @@ class DockerWorker {
           global.asyncDump ? '--require /worker/src/lib/async-dump' : '',
           '/worker/src/bin/worker.js',
           '--host test',
-          '--worker-group', 'random-local-worker',
+          '--worker-group', 'docker-worker',
           '--worker-id', this.workerId,
           '--provisioner-id', this.provisionerId,
           '--worker-type', this.workerType,

@djmitche
Copy link
Contributor

Not my PR, but I pushed that change :)

@walac
Copy link
Contributor

walac commented Jan 13, 2020

Not my PR, but I pushed that change :)

Ops, I commented in the wrong PR, it actually applies to yours, sorry

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants