Add empty portable-atomic-util crate #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Sep 12, 2022
Comment on lines
+30
to
+48
| if version.minor < 36 { | ||
| println!("cargo:rustc-cfg=portable_atomic_no_alloc"); | ||
| } | ||
| // raw_ref_macros stabilized in Rust 1.51 (nightly-2021-01-31) https://github.com/rust-lang/rust/pull/80886 | ||
| if !version.probe(51, 2021, 1, 30) { | ||
| println!("cargo:rustc-cfg=portable_atomic_no_raw_ref_macros"); | ||
| } | ||
| // unsafe_op_in_unsafe_fn stabilized in Rust 1.52 (nightly-2021-03-11): https://github.com/rust-lang/rust/pull/79208 | ||
| if !version.probe(52, 2021, 3, 10) { | ||
| println!("cargo:rustc-cfg=portable_atomic_no_unsafe_op_in_unsafe_fn"); | ||
| } | ||
|
|
||
| if version.nightly { | ||
| // `cfg(sanitize = "..")` is not stabilized. | ||
| let sanitize = env::var("CARGO_CFG_SANITIZE").unwrap_or_default(); | ||
| if sanitize.contains("thread") { | ||
| println!("cargo:rustc-cfg=portable_atomic_sanitize_thread"); | ||
| } | ||
| } |
Owner
Author
There was a problem hiding this comment.
IIRC, raw_ref_macros (addr_of! and addr_of_mut!), alloc, and cfg(sanitize = "thread") are needed to implement Arc. Some impls in #8 also need alloc.
Owner
Author
|
bors r+ |
Owner
Author
|
FYI @notgull |
Contributor
taiki-e
added
the
A-portable-atomic-util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an empty crate named
portable-atomic-util.For now, I'm considering putting the features proposed in #1 (#8) and #37 into this crate, but they may be merged into the main
portable-atomiccrate in the future.