Deprecate project* attributes #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Hm, deprecation of proc-macro requires Rust 1.40 (rust-lang/rust#65666). I'll add a build script. |
taiki-e
force-pushed
the
deprecate-project-attributes
branch
2 times, most recently
from
470a60c to
e69fa34
Compare
taiki-e
added
relnotes
A-project-attribute
taiki-e
force-pushed
the
deprecate-project-attributes
branch
2 times, most recently
from
67d1fea to
2e63bec
Compare
taiki-e
force-pushed
the
deprecate-project-attributes
branch
from
2e63bec to
fda3011
Compare
Owner
Author
|
bors r+ |
Contributor
|
Build succeeded: |
Owner
Author
|
Hmm... rustdoc doesn't seem to show deprecation note on re-export. https://docs.rs/pin-project/0.4.21/pin_project/#attributes So, it needs to add descriptions to project attributes. |
bors bot
added a commit
that referenced
this pull request
Jun 14, 2020
255: Add deprecation note to project attributes r=taiki-e a=taiki-e Addresses #244 (comment) Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates
#[project],#[project_ref], and#[project_replace]attributes in favor of the naming of projected type.Closes #225