-
Notifications
You must be signed in to change notification settings - Fork 20
Add Windows support using Powershell and winfsnotify #13
base: master
Are you sure you want to change the base?
Conversation
- Use `out` for error output: `err` is the just exit code
|
That's cool! |
|
Someone wants to remove the merge conflicts? :-) |
|
But isn't https://github.com/fsnotify/fsnotify already supporting all operating systems needed? From README I can see that there is inotify, kqueue and ReadDirectoryChangesW ... |
|
@tchap There are some issues with From https://docs.google.com/document/d/1-GQrFdDVrA57-ce0kbzSth4lQqfOMMRKpih3hPJmvoU/edit#, file change operations are an issue on Windows with fsnotify:
Additionally,
These deficiencies were enough to use winfsnotify instead of @mattes -- I'll take a look at cleaning up for merge this week! |
This PR adds support for Windows.
There are a few requirements:
rsync.exeandssh.exemust be in your path. This PR has been tested with cwrsyncpowershell.exeavailableThere is some wonkiness with
winfsnotify-- in the future it may be worth to use https://godoc.org/gopkg.in/fsnotify.v1 instead (which would also allow for Linux support to be implemented).