Log instead of ignoring failures in preview info requests (rdar://165722419) #990
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpenn
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
| } | ||
|
|
||
| #if canImport(Darwin) && canImport(os.log) | ||
| let previewsLogger = Logger(subsystem: "com.apple.dt.Previews", category: "swift-build") |
Collaborator
There was a problem hiding this comment.
How about subsystem=org.swiftlang.swift-build, category=preview-info?
Contributor
Author
There was a problem hiding this comment.
We need to match the existing subsystem that is used by our public logging profile to selectively un-redact when we need deeper diagnostics.
…722419) We'd like to rethink the preview info request types and payloads over time. But in the short term we need to get information about failed preview info requests in previews diagnostics we gather.
jonathanpenn
force-pushed
the
dev/jpenn/add-preview-info-logging
branch
from
01fc40d to
49f2a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to rethink the preview info request types and payloads over time. But in the short term we need to get information about failed preview info requests in previews diagnostics we gather.