Use SWIFT_MODULE_NAME (defaults to PRODUCT_MODULE_NAME) as argument for appintentsmetadataprocessor for correctness #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or appintentsmetadataprocessor for correctness
justin-s-kang
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Author
|
@swift-ci test |
owenv
approved these changes
Dec 17, 2025
Collaborator
|
@swift-ci test |
neonichu
approved these changes
Dec 17, 2025
jakepetroules
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently passing PRODUCT_MODULE_NAME to appintentsmetadataprocessor, but SWIFT_MODULE_NAME is more correct since the latter can override the former for things like type names and protocol conformances if set as a user defined build configuration.