Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

fixed error and added @NotNull/@Nullable annotations#31

Open
Haringat wants to merge 3 commits intoswaechter:masterfrom
Haringat:master
Open

fixed error and added @NotNull/@Nullable annotations#31
Haringat wants to merge 3 commits intoswaechter:masterfrom
Haringat:master

Conversation

@Haringat
Copy link

@Haringat Haringat commented May 24, 2019 •
edited
Loading

  • The RenderResponse class now has an "error" property in case the
    renderer threw an error
  • The whole project was given @NotNull/@Nullable annotation to improve
    code quality
  • Exceptions during rendering are now properly given to the future.

Marcel added 3 commits May 24, 2019 15:36
fixed error and added @NotNull/@nullable annotations
55d77e7 
- The RenderResponse class now has an "error" property in case the
renderer threw an error
- The whole project was given @NotNull/@nullable annotation to improve
code quality
reverted source level back to 1.8
95250c3
made the request/respones id a number according to the source code (h…
bd5057f 
…ttps://github.com/angular/universal/blob/master/modules/socket-engine/src/main.ts line 18/22)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Haringat