This repository was archived by the owner on May 7, 2025. It is now read-only.
sending http method for deleting user account #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the delete account option by ensuring that the HTTP request uses the DELETE method.
- Introduces the "DELETE" HTTP method in the API call for user account deletion.
- Confirms correct usage of authentication headers and base URL.
| account: AccountWithToken, | ||
| ): Promise<UserResponse> { | ||
| return ofetch<UserResponse>(`/users/${account.userId}`, { | ||
| method: "DELETE", |
There was a problem hiding this comment.
[nitpick] Consider extracting the HTTP method string to a constant or an enum to avoid magic strings and improve maintainability.
Suggested change
| method: "DELETE", | |
| method: HttpMethod.DELETE, |
Member
|
I wanna merge this did u test that it works? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes delete account option