Skip to content

Conversation

@sharimk2
Copy link

No description provided.

Copy link
Collaborator

@jhnwu3 jhnwu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Sharim! Thanks for the help! Can we implement some unit tests sorta like how paul does it here?

https://github.com/sunlabuiuc/PyHealth/blob/master/tests/core/test_sdoh.py

Basically, it helps to just test that the class itself works.

Other things would be adding to the docs/ (Cursor does a pretty good job here given some examples).

@@ -0,0 +1,158 @@
# SDOH Medical Coding Task
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway to refactor this as a *.py file or just have the prompt here in the llm.py file?

I guess another thing we could do is have a sdoh_icd9_llm/ directory for your work here.



class SDOHICD9LLM:
"""Admission-level SDOH ICD-9 V-code detector using an LLM."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more doc strings on how a user might use this model here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants