MIM-1: Trait-based rulesets #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying mimir with
|
| Latest commit: |
3f029d8
|
| Status: | 🚫 Build failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only have one ruleset implemented within Mimir. This ruleset treats rules with more requirements as more "specific" and only evaluates the most specific rule.
This behaviour is desirable for performance because we can sort the ruleset in descending order of specificity and avoid iterating over the entire ruleset (breaking out early if we find a matching rule).
However, there are scenarios in which we might want to willingly evaluate all rules in a ruleset, irrespective of specificity. For example, suppose we use a ruleset to store the behaviour for unlocking achievements. In that case, we want to evaluate and find all achievements that should be unlocked, not just the achievement with the most requirements (this is the behaviour that would currently happen in Mimir).
With this in mind, we should refactor the codebase to replace the concrete implementation of the current ruleset with a trait-based approach to define rulesets.