Refactoring: make the tool use published docker images + some other fixes#91
Open
GitGab19 wants to merge 1 commit intostratum-mining:mainfrom
Open
Refactoring: make the tool use published docker images + some other fixes#91GitGab19 wants to merge 1 commit intostratum-mining:mainfrom
GitGab19 wants to merge 1 commit intostratum-mining:mainfrom
Conversation
GitGab19
force-pushed
the
refactoring
branch
2 times, most recently
from
609f078 to
c09465c
Compare
GitGab19
force-pushed
the
refactoring
branch
15 times, most recently
from
220d542 to
48a183e
Compare
…and docker images support: - Added comprehensive environment variables to `.env` for Bitcoin Core IPC, pool, JDS, JDC, and translator proxy settings. - Introduced `bitcoin-core.dockerfile` for building Bitcoin Core from source. - Updated `docker-compose-config-a.yaml` and `docker-compose-config-c.yaml` to reflect new service names and configurations. - Removed outdated Dockerfiles and configurations related to previous implementations. - Enhanced README with setup instructions and environment variable details. - Updated `run-benchmarking-tool.sh` to generate the `.env` file dynamically based on user input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the benchmarking-tool to make it use the published docker images from dockerhub.
It also fixes other issues I encountered while refactoring it.