feat: add pull policy and dependencies#5
Open
average-gary wants to merge 1 commit intostratum-mining:mainfrom
Open
feat: add pull policy and dependencies#5average-gary wants to merge 1 commit intostratum-mining:mainfrom
average-gary wants to merge 1 commit intostratum-mining:mainfrom
Conversation
Add pull_policy: build to make sure images are built from their respective dockerfile. Added additional `depends_on` for services running aforementioned images to be built
Member
|
Could you please solve conflicts? I'm really sorry, but I force pushed some commits just to fix immediately the issues encountered today. Now I'm gonna start introducing changes by PRs 🤞 |
Member
|
Hey @average-gary, could you give us updates here? Why do we need to add a Also, there are conflicts since we changed many things during last months on |
Contributor
Author
|
Pull-policy was added so a stale cached image wouldn't impact the benchmark. iirc, I encountered this issue with one of the dependencies. It could also just be a manual decision by the user so probably not a critical change. |
Member
|
Does that mean that with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pull_policy: build to make sure images are built from their respective dockerfile.
Added additional
depends_onfor services running aforementioned images to be built