Add the new initialisation options to the Regent version#51
Add the new initialisation options to the Regent version#51LonelyCat124 wants to merge 1 commit intomasterfrom
Conversation
sergisiso
left a comment
sergisiso
left a comment
There was a problem hiding this comment.
@LonelyCat124 Just one suggestion regarding the init ordering but everything else looks fine.
| init_east(east_region[int2d({0,0})], SOLID_BOUNDARY) | ||
| end | ||
|
|
||
| init_north(north_region[int2d({0,0})]) |
There was a problem hiding this comment.
Note that I changed the order of boundary order inits to west north east south. This affects the value of the NE corner, so it may be better to change it here as well.
There was a problem hiding this comment.
Hmm if the value of the NE corner has changed I need to do a bit more work than reordering, as the east_region and north_region declarations are defined to be non-overlapping, so ordering is irrelevant (and they can execute in parallel). I'll have another look in a bit and check this matches still.
There was a problem hiding this comment.
It's only the value of the T-mask in the boundary region, not inside the simulation domain (in case that helps you).
There was a problem hiding this comment.
I think not - it shouldn't be a big change either way, the simulation domain is all initialised by init_centre (or the launcher since that is also done in parallel).
There was a problem hiding this comment.
I had forgotten about this - I'll try to look at this soon and fix it so this can be merged.
There was a problem hiding this comment.
Having just reviewed Sergi's new PR, I see this one is still open. Do you (eventually) want to proceed with it @LonelyCat124 ?
There was a problem hiding this comment.
I have forgotten what I needed to do - I think it would be good to do in principle but I don't remember what options I needed to add.
4 participants
I've not tested correctness of this, which I'll do later by comparing checksums with another build once I can get SFP to clone the repo. I'm going to make it ready to review as I think this shouldn't cause issues.