Open
Conversation
…ngler 2.0's refactors of ghc api (https://hsyl20.fr/home/posts/2022-05-03-modularizing-ghc-paper.html)
|
oh wow that's wonderful, thanks a lot for this work! |
|
Hi! Ran into this one today. Does this build with GHC 9.2 and is mostly safe to use? |
Author
|
the other pull request might work better for 9.2 but I don't remember when the API changes were made. I don't know enough about the GHC API and to tell whether this is still safe. The code means exactly the same as it did before. Whether that still makes sense on the ABI level is another matter. I was hoping someone who knows this better would help debug it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@drvink @Kleidukos this builds now and
make,loadandunsafeEvalmostly work, even on a relatively complicated test:I'm getting a solid full terminal of warnings such as this though:
I was getting those even on very basic tests and thought maybe it's because I had ghc flags different in my main project than in the
evaled code, but they're the same even when I tested: