Skip to content

Conversation

@Solpatium
Copy link
Contributor

Split from #11. Makes it possible to copy .{so, dylib, dll} files

${CMAKE_COMMAND} -E copy
${CMAKE_CURRENT_BINARY_DIR}/../libcrypto_c_exports.so
${CMAKE_CURRENT_SOURCE_DIR}/libcrypto_c_exports.so
${CMAKE_CURRENT_BINARY_DIR}/../libcrypto_c_exports.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try:
libcrypto_c_exports${CMAKE_SHARED_LIBRARY_SUFFIX}

Also for the OUTPUT and DEPENDS line

@Solpatium
Copy link
Contributor Author

Sorry for a late response, I was on vacation and then I was busy with something else :)

Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @Solpatium)


src/starkware/crypto/ffi/js/CMakeLists.txt line 2 at r2 (raw file):

add_custom_command(
    OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/libcrypto${CMAKE_SHARED_LIBRARY_SUFFIX}

Suggestion:

libcrypto_c_exports${CMAKE_SHARED_LIBRARY_SUFFIX}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants