-
Notifications
You must be signed in to change notification settings - Fork 723
feat: openapi spec cleanup for schemathesis fuzzing and cleaner API error responses #6756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: openapi spec cleanup for schemathesis fuzzing and cleaner API error responses #6756
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (72.56%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6756 +/- ##
===========================================
- Coverage 78.18% 72.56% -5.62%
===========================================
Files 580 580
Lines 361096 361211 +115
===========================================
- Hits 282312 262115 -20197
- Misses 78784 99096 +20312
... and 292 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
BowTiedRadone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simone-stacks Thanks for opening the PR! I've just wrapped up an initial review focused on the specification changes. More reviews to come, as I am trying to check them carefully and ensure we maximize the impact of this effort.
Description
Improves OpenAPI schema definitions for better API documentation accuracy and validation.
Also introduces proper 405/404/400 HTTP error responses with allow headers.
These changes improve schema accuracy for tools like Schemathesis and ensure the OpenAPI spec matches actual API behavior.
A summary of the findings can be found here.
Applicable issues
Additional info (benefits, drawbacks, caveats)
Benefits:
Caveats:
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo