-
Notifications
You must be signed in to change notification settings - Fork 723
fix: allow secp256k1-recover? to accept high-S signatures
#6644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: allow secp256k1-recover? to accept high-S signatures
#6644
Conversation
jcnelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We sure this fixes the chain sync test?
It definitely fixes the one I investigated, https://explorer.hiro.so/txid/0x86ef14fa87fb7de8aef4955290637a7b216d8a47378b7890a87065e41cc8e09c?chain=mainnet |
|
For this release (3.3.0.0.0) we are going to revert back to the old library for secp256k1 (#6645). We will come back to this fix with more time for proper testing. |
|
@brice-stacks Since the reversion to libsecp256k1 is complete, can this be closed? |
|
I think we may still want to switch to the new crate since it is nice that it is all Rust and it removes the need for the separate implementation for Wasm. We just need the time to properly test it. I can check and make sure that this draft implementation doesn't have the same discrepancy that the r1 implementation had. |
|
I confirmed that for secp256k1 here, I did use the correct |
Fixes discrepancy in updated secp256k1 implementation with old version.