feat: use stable rust toolchain #185
Open
+42
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
force-pushed
the
mauro/feat/use-stable-toolchain
branch
2 times, most recently
from
781a324 to
3638e78
Compare
Collaborator
Author
|
I'll need to update the required CI jobs before we can merge this PR, will do so after I get an approval. |
After hitting a small problem with MintMaker not being able to install the version of the rust compiler we were enforcing, we have decided to take a chance and start using the stable version of the toolchain as default. The stable version of the toolchain will be used in CI for building, testing and linting, as well as for building the upstream image. Since future releases of rust may break compilation of our code in unexpected ways (new linting, more strict lifetime enforcement, etc..), the existing CI pipeline has been extended to run using the nightly toolchain. This toolchain is 2 minor versions ahead of the latest stable release, so it should give us enough time to sort any issues that may arise before the breaking change gets stabilized. The release process documentation has been updated to pin the rust version on release branches and disable cargo updates from MintMaker, since these will break the same way they are broken now on main. No changes are needed on the konflux Containerfile, because the version used for those builds are already handled via the RPM lockfile.
Molter73
force-pushed
the
mauro/feat/use-stable-toolchain
branch
from
3638e78 to
fe163c1
Compare
ovalenti
reviewed
Jan 12, 2026
Contributor
ovalenti
left a comment
ovalenti
left a comment
There was a problem hiding this comment.
I read through the modifications proposed, and it all seemed fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After hitting a small problem with MintMaker not being able to install the version of the rust compiler we were enforcing, we have decided to take a chance and start using the stable version of the toolchain as default. The stable version of the toolchain will be used in CI for building, testing and linting, as well as for building the upstream image.
Since future releases of rust may break compilation of our code in unexpected ways (new linting, more strict lifetime enforcement, etc..), the existing CI pipeline has been extended to run using the nightly toolchain. This toolchain is 2 minor versions ahead of the latest stable release, so it should give us enough time to sort any issues that may arise before the breaking change gets stabilized.
The release process documentation has been updated to pin the rust version on release branches and disable cargo updates from MintMaker, since these will break the same way they are broken now on main.
No changes are needed on the konflux Containerfile, because the version used for those builds are already handled via the RPM lockfile.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be enough.