feat: sanitize paths generated by calling d_path #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
force-pushed
the
mauro/feat/sanitize-d-paths
branch
from
bec7609 to
f10cf81
Compare
The paths generated from calling bpf_d_path can have a " (deleted)" suffix when a file is removed from the system, this can mess with our files being reported, so some basic sanitization is added to these buffers.
A new test is added which builds and runs a small container with a Rust binary that deletes itself and accesses a monitored file. This will trigger an open event where the executable path retrieved by the `bpf_d_path` helper will add a " (deleted)" suffix, the test checks our code correctly strips this suffix.
Molter73
force-pushed
the
mauro/feat/sanitize-d-paths
branch
from
e4419d8 to
30ceda3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The paths generated from calling bpf_d_path can have a " (deleted)" suffix when a file is removed from the system, this can mess with our files being reported, so some basic sanitization is added to these buffers.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Created a small Rust binary that will delete its own executable and then try to access a file provided as an argument, this can be run standalone for manual checking. A new integration test was added which builds a container with this binary and then runs it to check the
(deleted)suffix is properly stripped from the executable path.