fix(react): allow preview panel to be fully collapsed#445
Merged
AriPerkkio merged 5 commits intostackblitz:mainfrom Apr 16, 2025
Merged
fix(react): allow preview panel to be fully collapsed#445AriPerkkio merged 5 commits intostackblitz:mainfrom
AriPerkkio merged 5 commits intostackblitz:mainfrom
Conversation
|
|
Contributor
Author
|
Seems like the multiple preview window e2e test is flaky. Even locally it will pass and not pass on subsequent runs without changing the code. |
Contributor
|
@isaacplmann could you show screenshots of before-after this change? I haven't seen that test case being flaky before. Could it be that it becomes flaky with this change when window is smalle enough? |
Contributor
Author
AriPerkkio
reviewed
Apr 15, 2025
@tutorialkit/astro
@tutorialkit/react
@tutorialkit/theme
@tutorialkit/types
@tutorialkit/runtime
commit: |
AriPerkkio
approved these changes
Apr 16, 2025
Contributor
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good, thanks! 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





My tutorial does not heavily use the preview panel, but always uses the terminal. This change allows the terminal to be open and the preview panel to be collapsed all the way (by the user). The initial size of the preview panel stays the same.