Skip to content

Parse all timestamps to POSIXct #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RasmusSkytte merged 39 commits into from
Jan 5, 2026
Merged

Parse all timestamps to POSIXct #202

RasmusSkytte merged 39 commits into from
Jan 5, 2026

Conversation

@RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Oct 30, 2025 •
edited by LasseEngboChr
Loading

Intent

Fixes #203

Approach

All timestamps created with db_timestamp() are now parsed to POSIXct (assuming the local timezone) and then passed to the databases for translation to corresponding formats.

Tests were failing on both diseasystore and on diseasy, so I created two PRs verify this fix works over there.

Linked to:

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

This was referenced Oct 30, 2025
Open
Draft
@RasmusSkytte RasmusSkytte self-assigned this Oct 30, 2025
@RasmusSkytte RasmusSkytte added the bug Something isn't working label Oct 30, 2025
@RasmusSkytte RasmusSkytte changed the title Tracking timestamp issue Timestamp issue for duckdb Oct 30, 2025
@RasmusSkytte RasmusSkytte marked this pull request as ready for review October 30, 2025 19:10
@RasmusSkytte RasmusSkytte requested review from a team, LasseEngboChr, SofiaOtero and kaare-gr and removed request for a team October 30, 2025 19:10
@RasmusSkytte RasmusSkytte marked this pull request as draft October 30, 2025 19:44
@RasmusSkytte
test(db_timestamp): Test different timestamps map to the same value
a33c795
@RasmusSkytte
test(db_timestamp): Imrpove test output on failure
ded6540
@RasmusSkytte
fix(test-db_timestamp): Convert to DBI::SQL before using dbgetQuery
8599690
@RasmusSkytte
debug(db_timestamp): Try to cast to UTC on duckdb
106b851
@RasmusSkytte
Revert "debug(db_timestamp): Try to cast to UTC on duckdb"
7f14583 
This reverts commit 106b851.
@RasmusSkytte
test(db_timestamp): Imrpove test output on failure
fd2a05e
@RasmusSkytte
fix(db_timestamp): Change how timezone is handled on duckcb
cfe5e03
@RasmusSkytte
chore(test-db_timestamp): Add missing newline
fdbe450
@RasmusSkytte
feat(db_timestamp): Cast all timestamps to POSIXct in the local timezone
84a1cb9
@RasmusSkytte
feat(Logger): Cast all timestamps to POSIXct in the local timezone
b1628d7
@RasmusSkytte
feat(test-db_timestamp): Improve error messages on failure
51a9780
@RasmusSkytte
fix(test-db_timestamp): Use as.character() over format for `ts_st…
cbc3bd2 
…r` to retain ms
@RasmusSkytte
feat(test-Logger): Imrpove error messages on failure
2682db5
@RasmusSkytte RasmusSkytte force-pushed the fix/duckdb-db_timestamp branch from cde1c73 to 79705c7 Compare October 31, 2025 12:52
@RasmusSkytte RasmusSkytte force-pushed the fix/duckdb-db_timestamp branch from e92dc42 to 81ee875 Compare November 3, 2025 22:42
@RasmusSkytte RasmusSkytte changed the title Timestamp issue for duckdb Parse all timestamps to POSIXct Nov 4, 2025
@RasmusSkytte RasmusSkytte force-pushed the fix/duckdb-db_timestamp branch from 70f9c9d to cd171da Compare November 4, 2025 11:57
@RasmusSkytte RasmusSkytte force-pushed the fix/duckdb-db_timestamp branch from ccc83ee to ede21e9 Compare November 4, 2025 12:23
@RasmusSkytte RasmusSkytte mentioned this pull request Nov 5, 2025
Open
2 tasks
@RasmusSkytte RasmusSkytte marked this pull request as ready for review November 5, 2025 11:32
LasseEngboChr
LasseEngboChr approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@LasseEngboChr LasseEngboChr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep enforcing the use of the system timezone - we may consider a future improvement that can handle e.g. UTC as reference tz.

@RasmusSkytte RasmusSkytte merged commit 8972bb7 into main Jan 5, 2026
33 checks passed
@RasmusSkytte RasmusSkytte deleted the fix/duckdb-db_timestamp branch January 5, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LasseEngboChr LasseEngboChr LasseEngboChr approved these changes

@kaare-gr kaare-gr Awaiting requested review from kaare-gr kaare-gr was automatically assigned from ssi-dk/ddf

@SofiaOtero SofiaOtero Awaiting requested review from SofiaOtero SofiaOtero was automatically assigned from ssi-dk/ddf

Assignees

@RasmusSkytte RasmusSkytte

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing tests on duckdb

3 participants

@RasmusSkytte @LasseEngboChr