fix attempt for issue #28 with --edit-script and --minimization --incoming-pop <file>#29
Open
pdreiter wants to merge 1 commit intosquaresLab:mainfrom
Open
fix attempt for issue #28 with --edit-script and --minimization --incoming-pop <file>#29pdreiter wants to merge 1 commit intosquaresLab:mainfrom
pdreiter wants to merge 1 commit intosquaresLab:mainfrom
Conversation
…file> where edits weren't being used with minimized when !minimize_patch is true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turnin request contains a fix to a genprog issue where edits weren't being used with minimized when !minimize_patch is true.
Tested solution on minimal scenario identified in issue #28, maximal set provided by Joe Renzullo, and covered all combination of command line cases for
--minimization,--edit-script,--incoming-pop <file>.It looks good in my testing, but please note that I didn't do a full regression test... also note that my update mirrors a similar construct in
minimization.ml @ 201-205