Conversation
Collaborator
Pull Request Test Coverage Report for Build 22164823756Details
💛 - Coveralls |
minjieqiu
changed the title
vivekr-splunk
approved these changes
Feb 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR adjusts the telemetry controller’s reconcile requeue interval to run more frequently, aiming to mitigate observed drift when using a 24-hour requeue period.
Changes:
- Reduced the telemetry requeue interval from 24 hours (86400s) to 6 hours (21600s).
- Updated the inline comment describing the telemetry send frequency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const ( | ||
| requeAfterInSeconds = 86400 // Send telemetry once a day | ||
| requeAfterInSeconds = 21600 // Send telemetry once every 6 hour |
There was a problem hiding this comment.
The inline comment has a grammar issue: "once every 6 hour" should be "once every 6 hours".
Suggested change
| requeAfterInSeconds = 21600 // Send telemetry once every 6 hour | |
| requeAfterInSeconds = 21600 // Send telemetry once every 6 hours |
|
|
||
| const ( | ||
| requeAfterInSeconds = 86400 // Send telemetry once a day | ||
| requeAfterInSeconds = 21600 // Send telemetry once every 6 hour |
There was a problem hiding this comment.
Constant name appears to have a typo ("requeAfterInSeconds" vs "requeueAfterInSeconds"). Since this is referenced only in this file, consider renaming it to the correctly spelled form to avoid confusion and improve searchability.
rlieberman-splunk
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We found that kubernete controller's re-queue timer is not precise. When the timer is set to one day, the next reconcile happens a few hours longer than a day.
What does this PR have in it?
Reduce the timer to every 6 hours to make it more frequent.
Key Changes
Reduce the timer to every 6 hours to make it more frequent.
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist