Rails 8.1 support #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Rails 8.1 routing API breaking changes for Resource and
SingletonResource initialization.
Key Changes:
1. Routing API Update (Rails 8.1):
- Rails 8.1 changed Resource.new and SingletonResource.new signatures
- Removed 4th parameter (options) from both constructors
- Updated signatures:
* Before: Resource.new(type, api_only, shallow, options)
* After: Resource.new(type, api_only, shallow)
- Add version-conditional logic in routing_ext.rb:
* Rails 8.1+: Use 3-argument constructor
* Rails < 8.1: Use 4-argument constructor
Files Modified:
- lib/jsonapi/routing_ext.rb:
* Fixed Resource.new call (line ~138)
* Fixed SingletonResource.new call (line ~64)
Test Results:
- Rails 6.1.7.10: ✅ 674/674 tests passing
- Rails 7.0.10: ✅ 674/674 tests passing
- Rails 7.1.6: ✅ 674/674 tests passing
- Rails 7.2.3: ✅ 674/674 tests passing
- Rails 8.0.4: ✅ 674/674 tests passing
- Rails 8.1.1: ⚠️ 664/674 tests passing (10 failures)
Rails 8.1 Remaining Issues (10 test failures):
1. JoinTreeTest: SQL generation issue (1 failure)
2. RequestTest: Relationship route 404 errors (5 failures)
3. RequestTest: JSON parse error message format change (4 failures)
All backward compatibility maintained for Rails 6.1-8.0.
Rails 8.1 is partially supported pending investigation of remaining failures.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Rails 8.1 introduced several breaking changes that required updates across routing, testing, and SQL generation: Routing changes (lib/jsonapi/routing_ext.rb): - Rails 8.1 changed Scope to not support []= operator - Resource.new signature changed (removed options parameter) - Solution: Use @jsonapi_resource_type instance variable to track resource type instead of @scope[:jsonapi_resource] - Updated resource_type_with_module_prefix to check instance variable - Maintains backward compatibility with Rails 4-8.0 Test compatibility (test/integration/requests/request_test.rb): - Rails 8.1 has more detailed JSON parse error messages - Updated test_put_invalid_json to accept multiple error formats - Now matches: "unexpected token at" OR "expected ... got:" OR "parse error" SQLite boolean representation (test/unit/active_relation_resource_finder/join_manager_test.rb): - Rails 8.1+ SQLite now uses TRUE instead of 1 for boolean values - Updated db_true helper with version check for Rails 8.1+ - Maintains support for older Rails versions (5.x-8.0) Test results: - Rails 6.1.7.10: 674/674 tests passing ✓ - Rails 7.0.10: 674/674 tests passing ✓ - Rails 7.1.6: 674/674 tests passing ✓ - Rails 7.2.3: 674/674 tests passing ✓ - Rails 8.0.4: 674/674 tests passing ✓ - Rails 8.1.1: 674/674 tests passing ✓ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: