Rails 7.1 support #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Rails 7.1 compatibility fixes while maintaining backward compatibility with Rails 6.1 and 7.0: Changes: - Fix version-conditional app initialization in test_helper.rb - Rails 7.1+ requires TestApp.initialize! before rails/test_help - Rails 6.1/7.0 require opposite order - Fix schema compatibility in active_record.rb - Change t.string :length option to :limit (Rails 7.1 deprecation) - Change t.references :references option to foreign_key: false - Disable SQLite foreign key constraints in test environment - Rails 7.1 enables strict FK constraints by default - Added PRAGMA foreign_keys = OFF for test compatibility Backward compatibility verified: - Rails 6.1.7.10: ✅ 674/674 tests passing - Rails 7.0.10: ✅ 674/674 tests passing Rails 7.1.6 status: - 664/674 tests passing (98.5%) - 1 failure: RequestTest expecting 422, got 0 - 9 errors: "Invalid response code: 0" in controller tests Remaining work: - Investigate and fix response code 0 errors - Get all 674 tests passing in Rails 7.1.6 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix status code handling for Rack 3.0+ compatibility: Root cause: - Rack 3.0+ deprecated :unprocessable_entity symbol in favor of :unprocessable_content - When JSONAPI::Error looked up :unprocessable_entity in Rack::Utils::SYMBOL_TO_STATUS_CODE, it returned nil, causing response status to be 0 instead of 422 - This broke 10 tests that expected proper error status codes Solution: - Add DEPRECATED_STATUS_SYMBOLS mapping in JSONAPI::Error - Implement status_code_for() helper method that: 1. Tries the symbol directly first (works for all non-deprecated symbols) 2. Falls back to new symbol if deprecated symbol not found 3. Returns nil-safe string result - Apply helper to both initialize() and update_with_overrides() methods This maintains full backward compatibility: - Rails 6.1 with Rack 2.x: :unprocessable_entity works directly - Rails 7.0 with Rack 2.x: :unprocessable_entity works directly - Rails 7.1+ with Rack 3.x: :unprocessable_entity maps to :unprocessable_content Test results: - Rails 6.1.7.10: ✅ 674/674 tests passing - Rails 7.0.10: ✅ 674/674 tests passing - Rails 7.1.6: ✅ 674/674 tests passing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: