Turn off shader clipping in VR #249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the pager was only assigned to meshes when the pager was first created (inside the 'if (!this.pager)' block). This meant that new paged SplatMesh objects added to the scene after the pager was already initialized would never get the pager assigned, causing 'PagedSplats.pager not set' errors when the renderer tried to update their LOD indices. The fix moves the pager assignment loop outside the conditional so it runs every frame when there's a pager, ensuring new meshes get the pager assigned.
- Add SparkPortals.ts: reusable portal implementation library - Add examples/newportal/index.html: example using SparkPortals - Update NewSparkRenderer.ts: fix lint error (remove redundant ternary) - Update index.ts: export SparkPortals
- Add PortalCrossCallback type for async portal crossing callbacks - Add onCross property to PortalPair interface - Update addPortalPair to accept onCross in options - Invoke callback in updateTeleportation after teleportation completes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the shader clipping logic doesn't correct use the two eye cameras in VR mode. Instead it creates two disk artifacts that float near the portal and move based on the users location. This patch turns off the shader clipping when using VR to avoid this obvious visual bug.