task-1 #6
Open
task-1 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spajic
approved these changes
Mar 7, 2019
|
|
||
| Вот какие проблемы удалось найти и решить | ||
|
|
||
| ### Ваша находка №1 |
| и конкатенацию строк (String#split) | ||
|
|
||
| ### Ваша находка №3 | ||
| Долго происходил процесс обработки сессий для каждого пользователя |
Owner
There was a problem hiding this comment.
Хорошо было бы добавить к каждому шагу больше конкретики.
Долго- это сколько?- Что было основной причиной?
- Как нашли причину?
- Как устранили?
- Как изменилась метрика?
| ie_counter = 0 | ||
| chrome_counter = 0 | ||
| users_browsers.each do |b| | ||
| ie_counter += 1 if ie_counter == 0 && /INTERNET EXPLORER/.match?(b) |
Owner
There was a problem hiding this comment.
А зачем проверка if ie_counter == 0?
Author
There was a problem hiding this comment.
я думал, что так можно сократить лишнюю проверку #match?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allocated memory by class
326_126_88 String
204_421_52 MatchData
161_736_32 Hash
768_498_4 Array
162_813_6 Date
163_120 User
Total allocated: 787_261_33 bytes (857028 objects)
100.00% 0.00% 857034.00 7.00 0.00 857027.00 1 Object#work
1mb: Finish in 0.6
~128Mb: Finish in ~110.46