trilinos: allow %llvm (with fc=flang) #3189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-triage
bot
requested review from
ccober6,
cgcgcg,
kuberry,
psakievich and
rppawlo
Contributor
Author
|
@rbberger Here is the change you helped me with. |
rbberger
reviewed
Jan 29, 2026
rbberger
changed the title
Member
|
LGTM. I'll let the Trilinos folks chime in before merging. |
rbberger
added
the
waiting-on-maintainer
Contributor
|
I can confirm that on a mac using apple-clang and gfortran, this works. The logic that is being replaced precedes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current recipe for
trilinosassumes that%llvmflavors will usefc=gfortran. This small change allows compiles withflang.