-
Notifications
You must be signed in to change notification settings - Fork 525
Added support for multiple-slurmd #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
w8jcik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry for the delay, I was travelling recently.
This change is clear and simple, and it can be merged.
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/acts/package.py
repos/spack_repo/builtin/packages/amrvis/package.py
repos/spack_repo/builtin/packages/autoconf_archive/package.py
repos/spack_repo/builtin/packages/automake/package.py
repos/spack_repo/builtin/packages/cabana/package.py
repos/spack_repo/builtin/packages/cmake/package.py
repos/spack_repo/builtin/packages/cusolvermp/package.py
repos/spack_repo/builtin/packages/gawk/package.py
repos/spack_repo/builtin/packages/gcc/package.py
repos/spack_repo/builtin/packages/go/package.py
repos/spack_repo/builtin/packages/grep/package.py
repos/spack_repo/builtin/packages/gromacs/package.py
repos/spack_repo/builtin/packages/hypre/package.py
repos/spack_repo/builtin/packages/intel_oneapi_mkl/package.py
repos/spack_repo/builtin/packages/jacamar_ci/package.py
repos/spack_repo/builtin/packages/malt/package.py
repos/spack_repo/builtin/packages/mimalloc/package.py
repos/spack_repo/builtin/packages/mvapich2/package.py
repos/spack_repo/builtin/packages/node_js/package.py
repos/spack_repo/builtin/packages/pdi/package.py
repos/spack_repo/builtin/packages/pdsh/package.py
repos/spack_repo/builtin/packages/py_hatch_fancy_pypi_readme/package.py
repos/spack_repo/builtin/packages/py_jaxlib/package.py
repos/spack_repo/builtin/packages/py_keras/package.py
repos/spack_repo/builtin/packages/py_pygithub/package.py
repos/spack_repo/builtin/packages/py_rpy2/package.py
repos/spack_repo/builtin/packages/py_ty/package.py
repos/spack_repo/builtin/packages/slurm/package.py
repos/spack_repo/builtin/packages/termcap/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/slurm/package.py:175: [F541] f-string is missing placeholders
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally! |
|
You still need to fix the pipeline. I think it just wants you to remove "f" from non-interpolated string. |
Added the option to enable compilation of Slurm with support for multiple instances of Slurmd.
Maintainer: @w8jcik