Skip to content

Conversation

@emwjacobson
Copy link
Contributor

Added the option to enable compilation of Slurm with support for multiple instances of Slurmd.

Maintainer: @w8jcik

Copy link
Contributor

@w8jcik w8jcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for the delay, I was travelling recently.

This change is clear and simple, and it can be merged.

@w8jcik
Copy link
Contributor

w8jcik commented Jan 31, 2026

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Jan 31, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link

spackbot-app bot commented Jan 31, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/acts/package.py
repos/spack_repo/builtin/packages/amrvis/package.py
repos/spack_repo/builtin/packages/autoconf_archive/package.py
repos/spack_repo/builtin/packages/automake/package.py
repos/spack_repo/builtin/packages/cabana/package.py
repos/spack_repo/builtin/packages/cmake/package.py
repos/spack_repo/builtin/packages/cusolvermp/package.py
repos/spack_repo/builtin/packages/gawk/package.py
repos/spack_repo/builtin/packages/gcc/package.py
repos/spack_repo/builtin/packages/go/package.py
repos/spack_repo/builtin/packages/grep/package.py
repos/spack_repo/builtin/packages/gromacs/package.py
repos/spack_repo/builtin/packages/hypre/package.py
repos/spack_repo/builtin/packages/intel_oneapi_mkl/package.py
repos/spack_repo/builtin/packages/jacamar_ci/package.py
repos/spack_repo/builtin/packages/malt/package.py
repos/spack_repo/builtin/packages/mimalloc/package.py
repos/spack_repo/builtin/packages/mvapich2/package.py
repos/spack_repo/builtin/packages/node_js/package.py
repos/spack_repo/builtin/packages/pdi/package.py
repos/spack_repo/builtin/packages/pdsh/package.py
repos/spack_repo/builtin/packages/py_hatch_fancy_pypi_readme/package.py
repos/spack_repo/builtin/packages/py_jaxlib/package.py
repos/spack_repo/builtin/packages/py_keras/package.py
repos/spack_repo/builtin/packages/py_pygithub/package.py
repos/spack_repo/builtin/packages/py_rpy2/package.py
repos/spack_repo/builtin/packages/py_ty/package.py
repos/spack_repo/builtin/packages/slurm/package.py
repos/spack_repo/builtin/packages/termcap/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/slurm/package.py:175: [F541] f-string is missing placeholders
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally!

@w8jcik
Copy link
Contributor

w8jcik commented Jan 31, 2026

You still need to fix the pipeline. I think it just wants you to remove "f" from non-interpolated string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants