Skip to content

Conversation

@ma96-gif
Copy link

@ma96-gif ma96-gif commented Oct 8, 2025

Description

Type of change

  • Bug fix
  • New feature
  • Protocol integration
  • Documentation update
  • Other (please describe):

Screenshots

Testing

Related Issues

Checklist

  • My code follows the project's style guidelines
  • I have added tests that prove my fix/feature works
  • All tests pass locally and in CI
  • I have updated documentation as needed
  • CI/CD checks pass
  • I have included screenshots for protocol screens (if applicable)
  • For security-related features, I have included links to related information

Additional Notes


Important

Adds ci.yaml for CI pipeline on master branch, including Node version reading, building, testing, and caching.

  • CI Configuration:
    • Adds ci.yaml to configure CI pipeline for master branch.
    • Triggers on push and pull_request events.
  • Jobs:
    • read-nvmrc: Reads Node version from .nvmrc.
    • Build-And-Test: Builds and tests the project using Node version from read-nvmrc.
  • Caching:
    • Caches pnpm and playwright dependencies.
    • Uses actions/cache@v4 for additional caching of .next/cache and other directories.
  • Build and Test Steps:
    • Installs dependencies with pnpm install --frozen-lockfile.
    • Builds project with pnpm build.
    • Checks code style with pnpm format:ci.
    • Runs tests with pnpm test:ci.

This description was created by Ellipsis for 867ffd8. You can customize this summary. It will automatically update as commits are pushed.

@vercel
Copy link

vercel bot commented Oct 8, 2025

@ma96-gif is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@ma96-gif ma96-gif marked this pull request as ready for review October 8, 2025 01:47
Copy link
Author

@ma96-gif ma96-gif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisar

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 867ffd8 in 58 seconds. Click for details.
  • Reviewed 95 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/ci.yaml:1
  • Draft comment:
    The PR description claims it resolves the transaction history issue, but this file only adds CI configuration without any app logic changes or tests for that bug. Please ensure the relevant code or tests are included.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that the relevant code or tests are included, which violates the rule against asking the author to ensure their change is tested or to confirm their intention. The comment also mentions the PR description, which is not allowed. Therefore, this comment should be removed.
2. .github/ci.yaml:40
  • Draft comment:
    Avoid using single quotes around the node-version expression in the matrix. Removing the quotes ensures the expression is correctly evaluated.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. .github/ci.yaml:87
  • Draft comment:
    The test step uses TEST_SERIAL_TIMEOUT from repository vars. Ensure this variable is defined or provide a default value to avoid runtime issues.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_Jk6ufnJ97bT1DtYb

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@rogaldh
Copy link
Contributor

rogaldh commented Oct 23, 2025

There is one already. Is it a bot or something?

@rogaldh
Copy link
Contributor

rogaldh commented Nov 10, 2025

@jacobcreech that could be closed it seems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants