-
Notifications
You must be signed in to change notification settings - Fork 506
Create ci.yaml #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create ci.yaml #710
Conversation
|
@ma96-gif is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
ma96-gif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revisar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 867ffd8 in 58 seconds. Click for details.
- Reviewed
95lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/ci.yaml:1
- Draft comment:
The PR description claims it resolves the transaction history issue, but this file only adds CI configuration without any app logic changes or tests for that bug. Please ensure the relevant code or tests are included. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to ensure that the relevant code or tests are included, which violates the rule against asking the author to ensure their change is tested or to confirm their intention. The comment also mentions the PR description, which is not allowed. Therefore, this comment should be removed.
2. .github/ci.yaml:40
- Draft comment:
Avoid using single quotes around the node-version expression in the matrix. Removing the quotes ensures the expression is correctly evaluated. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. .github/ci.yaml:87
- Draft comment:
The test step uses TEST_SERIAL_TIMEOUT from repository vars. Ensure this variable is defined or provide a default value to avoid runtime issues. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_Jk6ufnJ97bT1DtYb
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
There is one already. Is it a bot or something? |
|
@jacobcreech that could be closed it seems |
Description
Type of change
Screenshots
Testing
Related Issues
Checklist
Additional Notes
Important
Adds
ci.yamlfor CI pipeline onmasterbranch, including Node version reading, building, testing, and caching.ci.yamlto configure CI pipeline formasterbranch.pushandpull_requestevents.read-nvmrc: Reads Node version from.nvmrc.Build-And-Test: Builds and tests the project using Node version fromread-nvmrc.pnpmandplaywrightdependencies.actions/cache@v4for additional caching of.next/cacheand other directories.pnpm install --frozen-lockfile.pnpm build.pnpm format:ci.pnpm test:ci.This description was created by
for 867ffd8. You can customize this summary. It will automatically update as commits are pushed.