Use path.resolve for test download paths#349
Merged
SteveChurchillSWO merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
Import path and replace hardcoded relative file path strings with path.resolve in anomalies-, expenses- and resources-tests to create platform-independent paths for downloaded PNG/PDF comparisons. Commented-out CI test.fixme lines and removed minor trailing whitespace. This improves cross-OS reliability for file comparisons in the e2e tests.
dwolosz
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Import path and replace hardcoded relative file path strings with path.resolve in anomalies-, expenses- and resources-tests to create platform-independent paths for downloaded PNG/PDF comparisons. Commented-out CI test.fixme lines and removed minor trailing whitespace. This improves cross-OS reliability for file comparisons in the e2e tests.
Related issue number
https://softwareone.atlassian.net/browse/MPT-17698