Skip to content

MPT-16437 Update resource account mixin usage#205

Merged
albertsola merged 1 commit intomainfrom
MPT-16437/Mixins-fixes
Feb 3, 2026
Merged

MPT-16437 Update resource account mixin usage#205
albertsola merged 1 commit intomainfrom
MPT-16437/Mixins-fixes

Conversation

@albertsola
Copy link
Contributor

@albertsola albertsola commented Feb 2, 2026

Closes MPT-16437

  • Consolidated mixin imports across account resource modules to import from mpt_api_client.resources.accounts.mixins instead of individual submodules (account.py, account_users.py, accounts_users.py, buyers.py, erp_links.py, sellers.py, users.py)
  • Replaced dedicated imports for activatable_mixin, validate_mixin, invitable_mixin, and blockable_mixin with unified package-level imports
  • Updated import sources for: ActivatableMixin/AsyncActivatableMixin, ValidateMixin/AsyncValidateMixin, InvitableMixin/AsyncInvitableMixin, BlockableMixin/AsyncBlockableMixin
  • No behavioral changes or public API signature modifications; purely import refactoring

@albertsola albertsola requested a review from a team as a code owner February 2, 2026 17:39
@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Consolidates mixin imports across account resource modules by importing ActivatableMixin, AsyncActivatableMixin, InvitableMixin, AsyncInvitableMixin, BlockableMixin, AsyncBlockableMixin, ValidateMixin, and AsyncValidateMixin from the unified mpt_api_client.resources.accounts.mixins package instead of their previous submodules.

Changes

Cohort / File(s) Summary
Account modules
mpt_api_client/resources/accounts/account.py, mpt_api_client/resources/accounts/account_users.py, mpt_api_client/resources/accounts/accounts_users.py, mpt_api_client/resources/accounts/buyers.py, mpt_api_client/resources/accounts/erp_links.py, mpt_api_client/resources/accounts/sellers.py, mpt_api_client/resources/accounts/users.py
Replaced imports that referenced specific mixin submodules (e.g., activatable_mixin, invitable_mixin, blockable_mixin, validate_mixin) with imports from the consolidated package mpt_api_client.resources.accounts.mixins. No changes to class signatures or runtime logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Test Coverage Required ⚠️ Warning PR modifies 7 code files in accounts resource modules with import consolidation changes but includes no test file updates or additions. Add or update tests to verify the consolidated imports work correctly and don't break functionality in the accounts resource modules.
✅ Passed checks (2 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key (MPT-16437) in the correct MPT-XXXX format at the beginning.
Single Commit Required ✅ Passed The pull request contains exactly one commit consolidating all import path changes across seven modified files related to mixin usage in the accounts resources module.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • MPT-16437: Cannot read properties of undefined (reading 'map')

Comment @coderabbitai help to get the list of available commands and usage tips.

@albertsola albertsola force-pushed the MPT-16437/Mixins-fixes branch from 5eb02dc to 6c07042 Compare February 2, 2026 17:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

@albertsola albertsola merged commit aef0fb4 into main Feb 3, 2026
4 checks passed
@albertsola albertsola deleted the MPT-16437/Mixins-fixes branch February 3, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants