feat: optionally skip configure #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikcorg
force-pushed
the
feature/skip-configure
branch
2 times, most recently
from
385201f to
27cdc7a
Compare
Using an api key with limited (specific) permissions (purge subset of this service) the configure command will fail. Running the configure step should be optional, because it adds an implicit requirement on the token's permission grant.
nikcorg
force-pushed
the
feature/skip-configure
branch
3 times, most recently
from
2ba1f8f to
6a6e469
Compare
Author
|
Hi @softprops, did you have a chance to review this PR yet? |
when using this workflow only for the install, there is no value in enforcing the presence of the token.
nikcorg
force-pushed
the
feature/skip-configure
branch
from
6a6e469 to
ad7da34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an api key with limited (specific) permissions (purge subset of this service) the configure command will fail. Running the configure step should be optional, because it adds an implicity requirement on the token's permission grant.