pulls: make "merged" bool be Option as its not set when listing PRs #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Do you know if this is now detected by the presence of one of the other merge fields instead? |
Author
vrutkovs
force-pushed
the
pulls-list-fix
branch
from
f19997f to
66e74b8
Compare
vrutkovs
changed the title
vrutkovs
force-pushed
the
pulls-list-fix
branch
from
66e74b8 to
713bc40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Pull'smergedfield is made optional. Github's API doesn't set this field when all PRs are listed. It is being set when individual PR is being fetched.How did you verify your change:
Run
examples/pulls.rs- it should output a list of PRs. On current master it throwsError: Codec(Error("missing fieldmerged", line: 1, column: 14689))What (if anything) would need to be called out in the CHANGELOG for the next release:
Pull'smergedfield is made optional