Add wrapping and unwrapping capability to CKM_AES_GCM mechanism#641
Draft
keldonin wants to merge 1 commit intosofthsm:mainfrom
Draft
Add wrapping and unwrapping capability to CKM_AES_GCM mechanism#641keldonin wants to merge 1 commit intosofthsm:mainfrom
keldonin wants to merge 1 commit intosofthsm:mainfrom
Conversation
Contributor
Author
|
The build seems to fail with Appveyor. However, when looking closer to the logs:
Is something broken in the source code, that prevents building on Windows? |
Contributor
|
@keldonin I found another issue with AES GCM and have a fix in #664. Since the fix would have need to be applied also to the wrapping code, maybe we should think about extracting those AES parameter checks into a common function. I have also refactored the test d155341 to be able to test different sets of parameters. |
rijswijk
reviewed
Jan 5, 2022
| return CKR_ARGUMENTS_BAD; | ||
| } | ||
| iv.resize(CK_GCM_PARAMS_PTR(pMechanism->pParameter)->ulIvLen); | ||
| memcpy(&iv[0], CK_GCM_PARAMS_PTR(pMechanism->pParameter)->pIv, CK_GCM_PARAMS_PTR(pMechanism->pParameter)->ulIvLen); |
| iv.resize(CK_GCM_PARAMS_PTR(pMechanism->pParameter)->ulIvLen); | ||
| memcpy(&iv[0], CK_GCM_PARAMS_PTR(pMechanism->pParameter)->pIv, CK_GCM_PARAMS_PTR(pMechanism->pParameter)->ulIvLen); | ||
| aad.resize(CK_GCM_PARAMS_PTR(pMechanism->pParameter)->ulAADLen); | ||
| memcpy(&aad[0], CK_GCM_PARAMS_PTR(pMechanism->pParameter)->pAAD, CK_GCM_PARAMS_PTR(pMechanism->pParameter)->ulAADLen); |
Contributor
|
Please rebase on develop and mark as ready when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds wrapping and unwrapping capability to the
CKM_AES_GCMmechanism.It comes along with new cases to the test suite.